#1231 adding overflow: auto to warning models and error models#1232
Merged
#1231 adding overflow: auto to warning models and error models#1232
Conversation
dondi
approved these changes
Sep 24, 2025
Owner
dondi
left a comment
There was a problem hiding this comment.
I’ll approve the PR but we should eventually fix the spelling on the function name
| } | ||
|
|
||
| $("#warningsModal").modal("show"); | ||
| showWarningsModel(); |
Owner
There was a problem hiding this comment.
Good duplication catch and code consolidation!
| showWarningsModel(); | ||
| }; | ||
|
|
||
| var showWarningsModel = function () { |
Owner
There was a problem hiding this comment.
Minor thing, won’t block merging: we actually mean the modal dialog box here right? So I think the spelling on this function should be:
Suggested change
| var showWarningsModel = function () { | |
| var showWarningsModal = function () { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.