WIP: Fixed Demo Indicators out of sync bug and updated export modal and functionality#985
WIP: Fixed Demo Indicators out of sync bug and updated export modal and functionality#985
Conversation
dondi
left a comment
There was a problem hiding this comment.
Just a couple of tweaks and I think this will work!
…pleted UI of export to excel. Backend still needs to be redone
…es. Made minor name changes for clarity issues to the loader.py in the network database
…nce of the GRNsight database
…on others computers
…orking on export to excel
…ization diagnostics sheets are a bit finicky
dondi
left a comment
There was a problem hiding this comment.
Overall looks pretty good except for just a couple of code style fine points. Once those are changed I think this can go…
| let date = new Date(source.substring(i + 1)); | ||
| date = getFormattedDateTime(date); |
There was a problem hiding this comment.
Hmmm this is a little sketchy. Starting the date variable out as a Date and then replacing it with its string…JavaScript lets you do this but other languages won’t, and ideally we don’t get into the habit of doing this. If we create a new value, we should put that in a new variable
There was a problem hiding this comment.
I changed this as requested
| // these are part of the "meta" property | ||
| } else if (TWO_COL_SHEET_NAMES.includes(sheet.name)) { | ||
| output["test"][sheet.name] = parseTwoColumnSheet(sheet); | ||
| output["twoColumnSheets"][sheet.name] = parseTwoColumnSheet(sheet); |
There was a problem hiding this comment.
Any reason why this isn’t output.twoColumnSheets? (it’s written that way elsewhere)
There was a problem hiding this comment.
I changed it to to output.twoColumnSheets. It must of been residual from fixing linter errors.
dondi
left a comment
There was a problem hiding this comment.
Almost there! Just one little tweak. Values reflected here based on the latest capabilities of JavaScript:
- Use
constas much as possible - Declare variables at the deepest scope in which they’re needed
Co-authored-by: dondi <dondi@lmu.edu>
#976 Fixed this issue. The demo sidebar dropdown works as expected now.
#978 UI fixes and beginnings of the new excel export implementation.
#990 Fixed this issue. GRNsight properly handles when a database generated network does not have any regulatory connections.
#977 @ahmad00m also fixed the node coloring menu inactivated issue in this pr
#972 Fixed this issue. Edges are now counted correctly in the custom workbook title
#961 Documentation for loading database scripts completed