bench: Fix MSVC build error on 32-bit Windows #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
It seems this is failing to build with GCC on Linux, and with MINGW on Windows. |
size_t is `unsigned long int` which is a 32-bit integer on 32-bit Windows. The multiplication in malloc() then evaluates to a 32-bit integer which the compiler complains about. This is normally a warning, but since we use `-we4244` it's an error. src/bench/graphene-bench-utils.c(175): error C4244: 'function': conversion from 'gint64' to 'size_t', possible loss of data` The number of rounds will never exceed INT_MAX, so we can just use an int here.
94286b8 to
28800bb
Compare
Contributor
Author
|
Oof. I should've tested on Linux first. Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size_tisunsigned long intwhich is a 32-bit integer on 32-bit Windows. The multiplication inmalloc()below then evaluates to a 32-bit integer which the compiler complains about.This is normally a warning, but since we use
-we4244it's an error.src/bench/graphene-bench-utils.c(175): error C4244: 'function': conversion from 'gint64' to 'size_t', possible loss of data`
The number of rounds will never exceed INT_MAX, so we can just use an int here.