Fix replace_first filter for nil argument #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `replace_first` is called with a `nil` value as the string to be replaced, it raises an `ArgumentError`. This commit fixes this issue by adding a check for `nil` and returning the input string unchanged in that case, which is the expected behavior.
When `replace_first` is called with a `nil` value as the string to be replaced, it should behave like replacing with an empty string. This commit fixes this issue by using `to_str` to convert the `nil` value to an empty string before passing it to `String.replace`.
When `replace_first` is called with a `nil` value as the string to be replaced, it should behave like replacing with an empty string. This commit fixes this issue by using `to_str` to convert the `nil` value to an empty string before passing it to `String.replace`.
edgurgel
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
replace_firstfilter was crashing when the string to be replaced wasnil. This happened when an undefined variable was used as an argument to the filter. This change adds anilcheck to thereplace_firstfunction to prevent the crash and return the input string unmodified, which aligns with the behavior of other filters.