Accept function as custom_filters #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey thanks for the PR! Will review in the next couple of days! |
|
This is great! Any chance a new release could be made to include this change? |
Owner
|
Oops! My bad! 1.2.0 is out 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions
0.*it was possible to pass the opts to custom filters. It would attempt to call the filter with the opts appended to it first and then without the opts. This was lost in the transition to 1.0. The previous implementation could be problematic with, for example, default arguments, so I support it's removal, but I would still like the ability to pass context to filters that weren't explicitly passed in the template and I'd rather not resort to the process dict.This PR adds makes it possible for the caller to completely implement the filter logic themselves and additional context can be taken from the lambda's scope.