Skip to content

[Cloud Security ]add observer.vendor to cloud_security_posture package version 1.10#11017

Merged
maxcold merged 2 commits intoelastic:backport-cloud_security_posture-1.10from
maxcold:csp-add-observer-vendor-1-10
Sep 9, 2024
Merged

[Cloud Security ]add observer.vendor to cloud_security_posture package version 1.10#11017
maxcold merged 2 commits intoelastic:backport-cloud_security_posture-1.10from
maxcold:csp-add-observer-vendor-1-10

Conversation

@maxcold
Copy link
Copy Markdown
Contributor

@maxcold maxcold commented Sep 5, 2024 •
edited
Loading

Proposed commit message

Backport of the #10945 into currently released 1.10 package version as per requirement in elastic/kibana#188802

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  • build with elastic-package build
  • run stack with this package via elastic-package stack up -v -d
  • ingest data into findings and vulnerability datastream, check that observer.vendor is provided

Related issues

Screenshots

@maxcold maxcold added enhancement New feature or request Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Sep 5, 2024
@maxcold maxcold mentioned this pull request Sep 5, 2024
Closed
4 tasks
@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Sep 5, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 5, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@maxcold maxcold marked this pull request as ready for review September 5, 2024 13:37
@maxcold maxcold requested a review from a team as a code owner September 5, 2024 13:37
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 6, 2024

💚 Build Succeeded

History

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube Bot commented Sep 6, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
22.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@maxcold
Copy link
Copy Markdown
Contributor Author

maxcold commented Sep 9, 2024

tested on a 8.15.1 production deployment: installed 1.10.0 integration, then upgraded to 1.10.1 (installing via elastic-package) , after some time the index mapping and data view picked up observer.vendor field
Screenshot 2024-09-09 at 10 57 23

@maxcold maxcold merged commit 632871f into elastic:backport-cloud_security_posture-1.10 Sep 9, 2024
@maxcold maxcold deleted the csp-add-observer-vendor-1-10 branch September 9, 2024 08:59
This was referenced Sep 9, 2024
Merged
Merged
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@maxcold
[Cloud Security ]add observer.vendor to cloud_security_posture packag…
dd80881 
…e version 1.10 (#11017)

* add observer.vendor to cloud_security_posture package

* add observer.vendor to the ecs mappings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfirpeled kfirpeled kfirpeled left review comments

+1 more reviewer

@CohenIdo CohenIdo CohenIdo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maxcold @elasticmachine @kfirpeled @CohenIdo @andrewkroh