[cisco_ftd] Fix grok failure with username with spaces on ftd messageID.#11198
[cisco_ftd] Fix grok failure with username with spaces on ftd messageID.#11198aleksmaus merged 5 commits intoelastic:mainfrom aleksmaus:fix/cisco_ftd_grok
Conversation
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
taylor-swanson
left a comment
There was a problem hiding this comment.
I'm really not sure why these patterns were made to be so complicated. As these issues have come up, I've started taking this approach over in cisco_asa: https://github.com/elastic/integrations/blob/main/packages/cisco_asa/data_stream/log/elasticsearch/ingest_pipeline/default.yml#L935
At the end of the day, the values we extract are either made of "not angle brackets" or "not spaces", depending on which pattern in the grok is used. We definitely need to get out of the business of trying to validate these logs.
I highly recommend the same approach here.
|
@taylor-swanson I updated the grok patterns per your suggestion. Could you take another look and give it 👍 ? |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @aleksmaus |
|
|
Package cisco_ftd - 3.4.2 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd |
…ID. (elastic#11198) * [cisco_ftd] Fix grok failure with username with spaces on ftd messageID. * Update changelog PR number * Fix test files names * Change the pipeline grok per code review feedback
…ID. (elastic#11198) * [cisco_ftd] Fix grok failure with username with spaces on ftd messageID. * Update changelog PR number * Fix test files names * Change the pipeline grok per code review feedback




Proposed commit message
Fix grok failure with username with spaces on ftd messageID.
[cisco_ftd]: Can't Grok Username with spaces on ftd messageID 113039 #10721
It is currently just DATA pattern match, not sure if we should tighten this further.
Checklist
changelog.ymlfile.Related issues