-
Notifications
You must be signed in to change notification settings - Fork 519
[O365_metrics]Split and refactor other data streams. #12456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O365_metrics]Split and refactor other data streams. #12456
Conversation
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
viva_engage_groups_activity_group_detail |
5952.38 | 4016.06 | -1936.32 (-32.53%) | 💔 |
outlook_activity |
13888.89 | 6993.01 | -6895.88 (-49.65%) | 💔 |
To see the full report comment with /test benchmark fullreport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, didn't we decide this interval as 24 hrs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we noticed that reports occasionally get refreshed daily, so to prevent any data loss, we decided to call the API twice a day.
...trics/data_stream/outlook_app_usage_version_counts/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of convert processor usage in the pipelines. Which makes it hard to read.
Is it possible to do this ia script in painless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but since not all fields need conversion and the selection is conditional, applying the convert processor selectively was the most feasible approach for now. Using Painless would require more complex logic, but we can definitely explore it for future optimizations.
I understand your concern. While we split the datastreams and provided detailed names based on the reports, we also aimed to keep them concise to avoid overly long names. Where possible, we shortened them without losing essential information. The description clearly specifies what each datastream fetches. Similarly, we named data stream |
muthu-mps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For the users who has already installed 0.3.0 might have a different data stream(Viva engage) for yammer device usage data stream while upgrading to newer version. I hope this is okay as the integration is still in Beta.
- Change looks good to me otherwise!
packages/o365_metrics/data_stream/mailbox_usage_detail/fields/fields.yml
Outdated
Show resolved
Hide resolved
|
💚 Build Succeeded
History
cc @ritalwar |
Yes, since it's in beta, it's always recommended to use the latest version. Given that version 0.4.0 includes some fixes also as mentioned in the changelog, they should update to it. |
ishleenk17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Package o365_metrics - 0.4.0 containing this change is available at https://epr.elastic.co/package/o365_metrics/0.4.0/ |
* Split and refactor data streams
* Split and refactor data streams


Proposed commit message
This PR includes the following updates:
mailbox_usagedatastream into two separate datastreams:mailbox_usage_detailandmailbox_usage_quota_status.outlook_app_usagedatastream tooutlook_app_usage_version_counts.yammer_device_usagedatastream toviva_engage_device_usage_user_counts.report_dateas the timestamp when available; otherwise, defaults timestamp toreport_refresh_date.Checklist
changelog.ymlfile.Related issues
Screenshots