Skip to content

[Amazon Bedrock] Overview and Guardrails dashboard improvements#12493

Merged
agithomas merged 0 commit intoelastic:mainfrom
agithomas:obs-integrations-issue-169
Jan 28, 2025
Merged

[Amazon Bedrock] Overview and Guardrails dashboard improvements#12493
agithomas merged 0 commit intoelastic:mainfrom
agithomas:obs-integrations-issue-169

Conversation

@agithomas
Copy link
Copy Markdown
Contributor

@agithomas agithomas commented Jan 28, 2025

  • Enhancement

Proposed commit message

Minor improvements to Bedrock overview and guardrails dashboard labels. Added tool tips to the top-level metrics.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Dashboard layout review
  • Package upgrade verification
  • Screenshot verification

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

Related issues

#12422

Screenshots

Amazon Bedrock Overview Dashboard
aws_bedrock_invocation

aws_bedrock_chat_image


Amazon Bedrock Guardrails Dashboard
amazon_bedrock_guardrails_overview
amazon_bedrock_guardrails_invocation_details

@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:aws_bedrock Amazon Bedrock labels Jan 28, 2025
@agithomas agithomas self-assigned this Jan 28, 2025
@andrewkroh andrewkroh added the enhancement New feature or request label Jan 28, 2025
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@agithomas agithomas marked this pull request as ready for review January 28, 2025 08:12
@agithomas agithomas requested review from a team and muthu-mps January 28, 2025 08:12
@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Jan 28, 2025
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@agithomas agithomas added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jan 28, 2025
@muthu-mps
Copy link
Copy Markdown
Contributor

  • Request rates in the markdown - shouldn't this be invocation rates?
  • The Number of should be removed from the x-axis labels.

Screenshot 2025-01-28 at 2 45 38 PM

@agithomas
Copy link
Copy Markdown
Contributor Author

@muthu-mps , thanks for the feedback. I have corrected a few additional y-axis labels as well. Screenshots updated to reflect the change.

@muthu-mps
Copy link
Copy Markdown
Contributor

@agithomas,

While looking into the panel title and the breakdown title, I would recommend the naming for those could be aligned everywhere in a same way. WDYT?

  • Prompt and response whereaguardrails intervened - Prompt and response where guardrails intervened.
  • Invocations wheretheguardrails intervened - by policy type - Invocations where guardrails intervened - by policy type
  • Invocations where guardrails intervened.

Fix the case here:

https://github.com/elastic/integrations/blob/2819b13977e0d2a51be81b4b42ef5cf4c30501c8/packages/aws_bedrock/kibana/dashboard/aws_bedrock-14fd745a-d3c1-4ebe-bd25-00b465336cde.json#L2259

https://github.com/elastic/integrations/blob/2819b13977e0d2a51be81b4b42ef5cf4c30501c8/packages/aws_bedrock/kibana/dashboard/aws_bedrock-14fd745a-d3c1-4ebe-bd25-00b465336cde.json#L2905

nit: Check for copy in the title and remove them. https://github.com/elastic/integrations/blob/2819b13977e0d2a51be81b4b42ef5cf4c30501c8/packages/aws_bedrock/kibana/dashboard/aws_bedrock-14fd745a-d3c1-4ebe-bd25-00b465336cde.json#L495

@agithomas
Copy link
Copy Markdown
Contributor Author

@daniela-elastic , kindly refer to the comment and attached screenshot. If any changes are to be made, please let me know.

@daniela-elastic
Copy link
Copy Markdown

I'm fine with the recommended changes. Thank you

@agithomas
Copy link
Copy Markdown
Contributor Author

@muthu-mps , the changes to address your comment is included as part of the change. Kindly refer to the screenshots.

Copy link
Copy Markdown
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

  • 💚 Build #21088 succeeded a28011d89396cbc21bc0ea187eeb69ff8ee915a5
  • 💚 Build #21085 succeeded 2819b13977e0d2a51be81b4b42ef5cf4c30501c8
  • 💚 Build #21062 succeeded a3b67a15915c81992b3244650f25613c3c4dc93d

cc @agithomas

@elastic-sonarqube
Copy link
Copy Markdown

@agithomas agithomas merged this pull request into elastic:main Jan 28, 2025
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package aws_bedrock - 0.22.1 containing this change is available at https://epr.elastic.co/package/aws_bedrock/0.22.1/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…tic#12493)

* Minor improvements to the Amazon Bedrock overview and Amazon Bedrock guardrails dashboard labels.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…tic#12493)

* Minor improvements to the Amazon Bedrock overview and Amazon Bedrock guardrails dashboard labels.
@agithomas agithomas deleted the obs-integrations-issue-169 branch February 6, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:aws_bedrock Amazon Bedrock Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants