Skip to content

[backport][Ti_AbuseCH] - Added support for optional "Auth Key" request header across all data streams #13317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShourieG merged 6 commits into from
Mar 27, 2025
Merged

[backport][Ti_AbuseCH] - Added support for optional "Auth Key" request header across all data streams #13317

ShourieG merged 6 commits into from
Mar 27, 2025

Conversation

@ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Mar 26, 2025 •
edited
Loading

Type of change

  • bug

Proposed commit message

Added support for optional "Auth Key" request header across all data streams. This PR is done as a backport bugfix to version 2.6.0 and this PR, so that the feature is available to users with elastic stack 8.13.0 and above without having to upgrade to 8.18.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2025-03-21 at 10 43 28 PM

@ShourieG ShourieG requested a review from a team as a code owner March 26, 2025 14:28
@ShourieG ShourieG self-assigned this Mar 26, 2025
@ShourieG ShourieG added Integration:ti_abusech abuse.ch Team:Service-Integrations Label for the Observability Service Integrations team bugfix Pull request that fixes a bug issue enhancement New feature or request backport labels Mar 26, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 26, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Mar 26, 2025
@elasticmachine
Copy link

elasticmachine commented Mar 26, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG requested review from efd6 and removed request for efd6 March 27, 2025 01:20
kcreddy
kcreddy reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-27 at 3 04 31 PM

@ShourieG, not sure why your branch is out of sync with backport branch. Was there any changes to backport branch?

@ShourieG
Copy link
Contributor Author

ShourieG commented Mar 27, 2025 •
edited
Loading

@kcreddy, so there was a commit made by vault-plugin bot in the backport branch -

commit 9851206e7c83019c6033ff7ee84d4c663d964969 (HEAD, upstream/backport-ti_abusech-2.6)
Author: elastic-vault-github-plugin-prod <[email protected]>
Date:   Wed Mar 26 12:57:45 2025 +0000

    Add .buildkite and .ci to backport branch: backport-ti_abusech-2.6 from the main branch

This is just adding configs and ci files so this should be ok.

@kcreddy
Copy link
Contributor

kcreddy commented Mar 27, 2025 •
edited
Loading

@ShourieG , I think we should remove this label: Team:Service-Integrations, looks like its for Observability.

@ShourieG
Copy link
Contributor Author

ShourieG commented Mar 27, 2025

@ShourieG , I think we should remove this label: Team:Service-Integrations, looks like its for Observability.

yea, added by mistake

@ShourieG ShourieG removed the Team:Service-Integrations Label for the Observability Service Integrations team label Mar 27, 2025
@ShourieG ShourieG mentioned this pull request Mar 27, 2025
Merged
5 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 27, 2025

💚 Build Succeeded

History

cc @ShourieG

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Mar 27, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ShourieG ShourieG merged commit b83d356 into elastic:backport-ti_abusech-2.6 Mar 27, 2025
7 checks passed
@ShourieG ShourieG deleted the ti_abusech/bugfix-2.6.0 branch March 27, 2025 11:02
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 27, 2025

Package ti_abusech - 2.6.1 containing this change is available at https://epr.elastic.co/package/ti_abusech/2.6.1/

@kevinlincdf
Copy link

kevinlincdf commented Mar 28, 2025 •
edited
Loading

Thank you all.
The rate-limit problem was solved.

@ShourieG ShourieG mentioned this pull request Mar 28, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@ShourieG ShourieG

Labels

backport bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:ti_abusech abuse.ch Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShourieG @elasticmachine @kcreddy @kevinlincdf @andrewkroh