Skip to content

[cisco_ftd] Add Pasrsing for Some Extra Fields#13957

Merged
taylor-swanson merged 2 commits intoelastic:mainfrom
mohitjha-elastic:cisco_ftd-3.9.0
May 22, 2025
Merged

[cisco_ftd] Add Pasrsing for Some Extra Fields#13957
taylor-swanson merged 2 commits intoelastic:mainfrom
mohitjha-elastic:cisco_ftd-3.9.0

Conversation

@mohitjha-elastic
Copy link
Copy Markdown
Collaborator

Proposed Commit Message

cisco_ftd: add parsing for `EncryptPeerIP` and `VPN_Action` fields.

Previously, these fields were not handled in the pipeline.
This adds parsing logic to support `EncryptPeerIP` and `VPN_Action`, 
enabling their proper processing in the data flow.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Clone integrations repo.
Install the elastic package locally.
Start the elastic stack using the elastic package.
Move to integrations/packages/cisco_ftd directory.
Run the following command to run tests.
elastic-package test -v

Related issues

  • Enhancements repo - 23222

Add parsing for  and  fields that was not mapped previously.
@mohitjha-elastic mohitjha-elastic self-assigned this May 21, 2025
@mohitjha-elastic mohitjha-elastic requested a review from a team as a code owner May 21, 2025 07:32
@mohitjha-elastic mohitjha-elastic added enhancement New feature or request Integration:cisco_ftd Cisco FTD Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels May 21, 2025
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube
Copy link
Copy Markdown

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @mohitjha-elastic

@andrewkroh andrewkroh added the Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] label May 21, 2025
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Copy Markdown
Contributor

@jrmolin jrmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay, but i don't see how the tcp moved to udp. please verify that

"data_stream": {
"dataset": "cisco_ftd.log",
"namespace": "ep",
"namespace": "84072",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elastic-package sometimes select a new sample event randomly and the order itself isn't deterministic hence the changes related to the sample events and readme is intentional.

},
"input": {
"type": "tcp"
"type": "udp"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please verify this is also correct -- i don't see evidence of it.

"hostname": "firepower"
},
"input": {
"type": "tcp"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@taylor-swanson
Copy link
Copy Markdown
Contributor

seems okay, but i don't see how the tcp moved to udp. please verify that

@jrmolin @mohitjha-elastic,

So I've noticed that elastic-package will sometimes select a new sample event. Could be that the logic to select which event to use changed, or the order itself isn't deterministic, but either way, it's usually not an issue. I haven't reviewed the changes yet, but I almost always ignore changes to the sample event.

Copy link
Copy Markdown
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Regarding the sample event changes, seems like it just chose the UDP input one this time. Other field changes seem consistent with newer agent versions.

@mohitjha-elastic mohitjha-elastic requested a review from jrmolin May 22, 2025 07:09
@taylor-swanson taylor-swanson merged commit cd934c8 into elastic:main May 22, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package cisco_ftd - 3.9.0 containing this change is available at https://epr.elastic.co/package/cisco_ftd/3.9.0/

anupratharamachandran pushed a commit to anupratharamachandran/integrations that referenced this pull request Jun 2, 2025
* Add parsing for EncryptPeerIP and VPN_Action fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_ftd Cisco FTD Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants