Skip to content

[O11y][Hadoop] Replace format of date processor from epoch_millis to UNIX_MS#5098

Merged
kush-elastic merged 6 commits intoelastic:mainfrom
chavdaharnish:package-hadoop_pipeline_test
Feb 22, 2023
Merged

[O11y][Hadoop] Replace format of date processor from epoch_millis to UNIX_MS#5098
kush-elastic merged 6 commits intoelastic:mainfrom
chavdaharnish:package-hadoop_pipeline_test

Conversation

@harnish-crest-data
Copy link
Copy Markdown
Contributor

@harnish-crest-data harnish-crest-data commented Jan 25, 2023 •
edited
Loading

  • Bug

What does this PR do?

  • epoch_millis processor silently passes the random date in the pipeline.
  • Replace format of date processor from epoch_millis to UNIX_MS in application and datanode data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-crest-data harnish-crest-data requested a review from a team as a code owner January 25, 2023 07:55
kush-elastic
kush-elastic approved these changes Jan 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 25, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-02T13:08:47.250+0000

  • Duration: 21 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 52
Skipped 0
Total 52

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 25, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (47/47) 💚 3.846
Lines 99.18% (605/610) 👎 -0.82
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic added bug Something isn't working, use only for issues Integration:hadoop Hadoop Team:Service-Integrations Label for the Observability Service Integrations team labels Jan 25, 2023
@harnish-crest-data harnish-crest-data marked this pull request as draft February 2, 2023 05:23
@harnish-crest-data harnish-crest-data marked this pull request as ready for review February 2, 2023 13:34
@harnish-crest-data harnish-crest-data changed the title [O11y][Hadoop] Match timestamps without year in pipeline tests with regex [O11y][Hadoop] Replace format of date processor from epoch_millis to UNIX_MS Feb 3, 2023
@agithomas agithomas requested a review from ishleenk17 February 9, 2023 09:21
ishleenk17
ishleenk17 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kush-elastic kush-elastic merged commit 8f47d9f into elastic:main Feb 22, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 22, 2023

Package hadoop - 0.4.1 containing this change is available at https://epr.elastic.co/search?package=hadoop

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@harnish-crest-data @agithomas
[O11y][Hadoop] Replace format of date processor from epoch_millis to …
a469ecb 
…UNIX_MS (elastic#5098)

* update pipeline test

* resolve merge conflicts

* update changelog.yml

* update patch version for hadoop package

* Replace format of date processor from epoch_millis to UNIX_MS
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@harnish-crest-data @agithomas
[O11y][Hadoop] Replace format of date processor from epoch_millis to …
6ce66c2 
…UNIX_MS (elastic#5098)

* update pipeline test

* resolve merge conflicts

* update changelog.yml

* update patch version for hadoop package

* Replace format of date processor from epoch_millis to UNIX_MS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

@agithomas agithomas Awaiting requested review from agithomas

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest-data harnish-crest-data

Labels

bug Something isn't working, use only for issues Integration:hadoop Hadoop Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harnish-crest-data @elasticmachine @kush-elastic @ishleenk17