Pretty output Flatpak package origins#1962
Merged
danirabbit merged 3 commits intomasterfrom Dec 29, 2022
Merged
Conversation
Member
|
Did we already try getting the title as in #1310? It sounds like there's a user-facing remote title string we should be using that we don't have to hard code |
Member
Author
|
@danirabbit thanks for mentioning #1310 :) |
danirabbit
approved these changes
Dec 29, 2022
Member
danirabbit
left a comment
There was a problem hiding this comment.
Nice job! Works as expected here. Fallbacks look good. And no hardcoding :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1310
Before
After