Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get settings base from CMake variable #528

Closed
wants to merge 3 commits into from
Closed

Get settings base from CMake variable #528

wants to merge 3 commits into from

Conversation

codygarver
Copy link
Contributor

No description provided.

tintou
tintou requested changes Nov 6, 2017
View reviewed changes
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve this until I have real reasons to change this variable

@cassidyjames
Copy link
Contributor

@tintou the idea was to make it easier for downstreams. But pop-os/shop has reverted to just using the same namespace, so 🤷‍♂️

@tintou
Copy link
Member

tintou commented Jan 16, 2018

@cassidyjames Yeah, that's because there is no reason for downstream to change this

@danirabbit
Copy link
Member

Closing since the only downstream that would use this doesn't want to use this

@danirabbit danirabbit closed this Jan 26, 2018
@tintou tintou deleted the settings-variable branch January 26, 2018 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou requested changes

Assignees
No one assigned
Labels
Status: In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codygarver @cassidyjames @tintou @danirabbit