Build style switch buttons dynamically from gsettings#434
Closed
davidmhewitt wants to merge 13 commits intomasterfrom
Closed
Build style switch buttons dynamically from gsettings#434davidmhewitt wants to merge 13 commits intomasterfrom
davidmhewitt wants to merge 13 commits intomasterfrom
Conversation
3 tasks
jeremypw
requested changes
Aug 23, 2018
Collaborator
jeremypw
left a comment
There was a problem hiding this comment.
This works, but looks a bit weird if there are more (or less) than three styles in the list of available styles.
added 2 commits
November 27, 2019 11:04
# Conflicts fixed: # data/Application.css # src/Widgets/HeaderBar.vala
Collaborator
|
Last commit lays out buttons evenly if > 3 styles. Also applies actual style to the background and text of the button. Focuses the current style button on opening menu. Styling details for example only. To be specified by UI team. |
Collaborator
|
@davidmhewitt Converting to draft as has conflicts, unaddressed issues and no recent activity. Please feel free to close or reopen for review after fixing conflicts as desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #395
Adds a key to gsettings that contains a list of style schemes to be shown on the buttons in the menu. The buttons are then built by loading colours and titles from the style scheme itself.
Allows downstreams to override which styles they want to display a selection of easier.