Use CSS properties defined in :root for exporting colors#756
Merged
danirabbit merged 3 commits intoelementary:mainfrom Mar 18, 2025
wpkelso:styles-colors
Merged
Use CSS properties defined in :root for exporting colors#756danirabbit merged 3 commits intoelementary:mainfrom wpkelso:styles-colors
danirabbit merged 3 commits intoelementary:mainfrom
wpkelso:styles-colors
Conversation
danirabbit
requested changes
Mar 18, 2025
Member
danirabbit
left a comment
There was a problem hiding this comment.
This doesn't actually do anything in our current version of GTK and adds an error: (granite-7-demo:23978): Gtk-WARNING **: 10:22:35.858: Theme parser error: Granite.css:1:1-6: Unknown name of pseudo-class but it doesn't appear to exactly break anything.
Except we can't remove the old color variables because that is an API break and apps use those. We should basically just remove those when we're absolutely ready to break api and bump to Granite 8 (or 9 I guess)
Member
Author
|
Looks like the docs I'm referencing are 4 minor versions newer than what we're using 🙃 |
danirabbit
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.gtk.org/gtk4/css-properties.html#non-css-colors
Also adds Latte into the mix, since it seems it never got added