Conversation
wpkelso
reviewed
Apr 9, 2025
Member
wpkelso
left a comment
There was a problem hiding this comment.
I like this styling more than the old version, but it seems like we're expecting developers to construct the window in a specific way to achieve this. Is that actually the case? And if it is, should we be thinking about a more ergonomic way to let developers use this?
Member
Author
|
@wpkelso It's way more fucky in the demo because we don't have Adw.ToolbarView. Here's an example of what the diff looks like in practice: elementary/iconbrowser#64 |
wpkelso
approved these changes
Apr 9, 2025
Member
wpkelso
left a comment
There was a problem hiding this comment.
I'm happy to merge this, then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really thin header styles are out of fashion. We are currently carrying custom CSS for H2 headers in Icon Browser and Settings for example. So update to match those:
Add a title to demo page so we can use it in context