Skip to content

Revert "Fix #117: Show icons for daemons (#118)"#122

Merged
marbetschar merged 5 commits intomasterfrom
revert-118-daemon-icon
Sep 6, 2021
Merged

Revert "Fix #117: Show icons for daemons (#118)"#122
marbetschar merged 5 commits intomasterfrom
revert-118-daemon-icon

Conversation

@meisenzahl
Copy link
Copy Markdown
Member

@meisenzahl meisenzahl commented May 15, 2021

This reverts commit a6d20d5.

Please revert this. We shouldn't be loading desktop files from the autostart folder. This folder is only for desktop files that should be launched with the session (and they don't even need to be fully formed desktop files). Hence why this isn't in the standard lookup path for DesktopAppInfo.

If something (a daemon or otherwise) wants to send notifications, it should install a desktop file to an XDG applications path (e.g. /usr/share/applications). If it should be hidden from the applications menu because it's a daemon, use the NoDisplay key.

Originally posted by @davidmhewitt in #118 (comment)

@meisenzahl meisenzahl requested a review from danirabbit May 15, 2021 05:46
@jeremypw jeremypw requested a review from davidmhewitt June 23, 2021 17:27
@jeremypw
Copy link
Copy Markdown

Assigning to David Hewitt as it is pursuant to his request.

@marbetschar marbetschar mentioned this pull request Sep 6, 2021
2 tasks
Copy link
Copy Markdown
Member

@marbetschar marbetschar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meisenzahl thanks for reverting my this-was-not-so-good change :)

@marbetschar marbetschar merged commit 8a44793 into master Sep 6, 2021
@marbetschar marbetschar deleted the revert-118-daemon-icon branch September 6, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants