Conversation
danirabbit
left a comment
There was a problem hiding this comment.
Thanks for submitting this pull request! I left a few comments inline
|
|
It seems I need to port the logic to calculate sunrise and sunset from gnome-settings-daemon to Vala 🙈 |
|
It works 🤓 |
|
Related to #2 |
|
One other question I had: what is the UX of the failure state here, i.e. if GeoClue can't get a location? Do we have default times to fall back to (like 8 PM to 6 AM or something), will the dark style just never trigger, or will it potentially trigger at a strange time? |
|
That's actually something I was thinking about as well. It looks like GSD saves last known coordinates for night light. It might be a good thing for us to do that too and fall back to some reasonable time if that's never been set before |
|
Does anyone have an idea how I can query sunrise and sunset via DBUS? Originally posted by @meisenzahl in elementary/gala#863 (comment)
So sane defaults as suggested by @cassidyjames? |
davidmhewitt
left a comment
There was a problem hiding this comment.
Nice work! I've added an initial set of comments about the code.
davidmhewitt
left a comment
There was a problem hiding this comment.
Thanks for the changes, starting to look better!
I have another few comments
davidmhewitt
left a comment
There was a problem hiding this comment.
This code looks really good now. I've left two very minor comments.
I've done some limited testing and it seems to work well too.
Thanks again for all your work on this, and sorry it took so long to re-review.
|
I should add that I'm happy for this to be merged once my last two comments above are resolved! |
|
@davidmhewitt Ready for review |
|
@danrabbit Do you want to review? 🙂 |
|
I've been running this for a while now so functionality works as expected in my usage. Nice job :) |
Moved from elementary/gala#863