Conversation
…oard-plug-about into add-support-for-fwupd
…oard-plug-about into add-support-for-fwupd
danirabbit
left a comment
There was a problem hiding this comment.
Something I noticed is that this introduces a significant lag when first opening the page. There are probably some operations that need to be made asynchronous from the view construction
|
I'm getting a real big lag when first opening the System plug again :( |
|
@danrabbit ah, oops, I wonder if that's related to my merge earlier. Does it go away if you install |
|
@davidmhewitt ah yup, I think that's it. Created #171 |
davidmhewitt
left a comment
There was a problem hiding this comment.
I'm happy with the code, but I have not conducted any testing. Nice work @meisenzahl !
|
@davidmhewitt thank you for your reviews and constructive feedback. |
danirabbit
left a comment
There was a problem hiding this comment.
From the testing I've done, I'm happy with this as an MVP. I think we can wait until follow ups to iterate on the design and add features. But this does the thing as far as I'm concerned:)
|
I created some issues:
Feel free to create some more if I missed something :) |
Closes #123