Skip to content

Handle flatpak+https scheme#170

Merged
danirabbit merged 4 commits intomainfrom
handle-flatpak+https-scheme
Jul 31, 2024
Merged

Handle flatpak+https scheme#170
danirabbit merged 4 commits intomainfrom
handle-flatpak+https-scheme

Conversation

@meisenzahl
Copy link
Copy Markdown
Member

Closes #169

@meisenzahl
Copy link
Copy Markdown
Member Author

I use GLib.File.copy to download the FlatpakRef. This was the easiest way without adding new external dependencies.

@meisenzahl meisenzahl assigned tintou and unassigned tintou Jul 29, 2024
@meisenzahl meisenzahl requested a review from tintou July 29, 2024 10:34
Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, just one request to make sure we throw an error dialog or I can't remember if Sideload has an error view. Something that the user can see the error

@meisenzahl
Copy link
Copy Markdown
Member Author

In order to be able to display an error to a user in the ErrorView, I unfortunately had to move the logic for parsing the Flatpak file to the MainWindow. @danirabbit let me know what you think.

Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey nice. I didn't realize that so many of these other errors were silent as well. Thanks for fixing those! Seems like everything is working as expected. Good job!

@danirabbit danirabbit merged commit 96e57ff into main Jul 31, 2024
@danirabbit danirabbit deleted the handle-flatpak+https-scheme branch July 31, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handke flatpak+https scheme

3 participants