This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Make UKF implementation work for dynamic dims#663
Merged
Conversation
akhilles
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original goal of this PR was to make the UKF work with Python, but it turns out the changes needed were way more than I expected. So I'm splitting the PR into this one, which makes the necessary changes to
noxandroci-adcs, and a second one for the Python integration.For nox the major push has been to relax type bounds that only worked with
ConstDim. For the most part this means instead of getting the dimension withD1::DIMyou instead callD1::array_shape(&arr.buf). In addition I made the following changes:array.rsintomod.rsand arepr.rsfileDimin ArrayDim to Shape to disambiguate the type level dimension and the potentially dynamic shapemapfunction toTensorwhich maps just along the top-level dimconcat_manywork with iterators instead of fixed length arraysIn roci-adcs the Nox changes were used to replace all the uses of
Const<N>with generic dimensions. I have kept theConstapi as a wrapper, because that is safer for Rust users. There is a loosely typed internal API that the Python wrapper will use.