Closed
Conversation
Owner
|
We've updated winit now: Maybe it's time to revisit this PR? |
emilk
added a commit
that referenced
this pull request
Sep 9, 2024
Before making this PR, I did take notice of a similar PR, #4833, but as it appears to be abandoned, I decided to make this PR. **Missing** One of the checks doesn't pass as wgpu still uses glow `0.13.1` ```shell cargo deny --all-features --log-level error --target aarch64-apple-darwin check ``` * [x] I have followed the instructions in the PR template --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Before making this PR, I did take notice of a similar PR, emilk#4833, but as it appears to be abandoned, I decided to make this PR. **Missing** One of the checks doesn't pass as wgpu still uses glow `0.13.1` ```shell cargo deny --all-features --log-level error --target aarch64-apple-darwin check ``` * [x] I have followed the instructions in the PR template --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change
By updating
glowto0.14, this will pull a multiude of beneficial changes, such as Make debug message callback Send + Sync.which is important when drawing
three-dwindows in a glow context.Glow update: grovesNL/glow#296
Description of Changes
glowto0.14Verification
./scripts/check✅Labels:
dependencies