Skip to content

Patches from emscripten 3.1.73 - #12

Merged
aheejin merged 1 commit into
emscripten-libs-18from
emscripten-libs-18-downstream
Dec 10, 2024
Merged

aheejin merged 1 commit into
emscripten-libs-18from
emscripten-libs-18-downstream

Conversation

@aheejin

@aheejin aheejin commented Dec 5, 2024

Copy link
Copy Markdown
Member

This adds additional downstream changes to the branch, which were added after LLVM 18 update until now.

This adds additional downstream changes to the branch, which were added
after LLVM 18 update until now.
@aheejin
aheejin requested a review from sbc100 December 5, 2024 03:01
@aheejin
aheejin merged commit 3bd640c into emscripten-libs-18 Dec 10, 2024
@aheejin
aheejin deleted the emscripten-libs-18-downstream branch December 10, 2024 23:56
aheejin pushed a commit that referenced this pull request Oct 19, 2026
After the changes made in llvm#230518. They are correct, but broke an
assumption that I had made that there would be no live code between the
set of nops and the breakpoint location.

Before:
 730:   d503201f        nop
 734:   14000001        b       738 <place_break_here>
0000000000000738 <place_break_here>:

That "b" is dead code, but -

After:
 73c:   d503201f        nop
 740:   14000001        b       744 <foo+0x30>
 744:   b9400fe0        ldr     w0, [sp, #12]
0000000000000748 <place_break_here>:
 748:   d503201f        nop

That "ldr" is not.

To fix this, use a single inline asm block so we
can control the layout. The only drawback to that
is we have to spell out the branch over the
dead code.

Turns out most architectures are just "b" though.
Only tested on AArch64 but I did check that the
instructions assembled for the other targets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants