Repository navigation
Patches from emscripten 3.1.73 - #12
Merged
Merged
Conversation
This adds additional downstream changes to the branch, which were added after LLVM 18 update until now.
sbc100
approved these changes
Dec 5, 2024
aheejin
pushed a commit
that referenced
this pull request
Oct 19, 2026
After the changes made in llvm#230518. They are correct, but broke an assumption that I had made that there would be no live code between the set of nops and the breakpoint location. Before: 730: d503201f nop 734: 14000001 b 738 <place_break_here> 0000000000000738 <place_break_here>: That "b" is dead code, but - After: 73c: d503201f nop 740: 14000001 b 744 <foo+0x30> 744: b9400fe0 ldr w0, [sp, #12] 0000000000000748 <place_break_here>: 748: d503201f nop That "ldr" is not. To fix this, use a single inline asm block so we can control the layout. The only drawback to that is we have to spell out the branch over the dead code. Turns out most architectures are just "b" though. Only tested on AArch64 but I did check that the instructions assembled for the other targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds additional downstream changes to the branch, which were added after LLVM 18 update until now.