Fix/update with other branches #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 78211a9.
…hub.com/ensdomains/ensjs into add-register-commit-without-namewrapper
Increase test output verbosity in GitHub Actions to help diagnose deployment and nonce-related issues in CI environment. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Temporarily disable legacy name generation (type === 'legacy' && false) to test if the EthEstimateGas/nonce errors are specific to legacy transactions or affect all transaction types. This will help identify whether the gas estimation failure originates from the legacy generator or the wrapped generator path. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Change condition to (type === 'legacy' || true) to force all transactions to use the legacyNameGenerator path, isolating whether the issue is specific to wrapped transactions. This test run will show if the EthEstimateGas/nonce errors occur when only using legacy (unwrapped) name registration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Revert deploy condition to original (type === 'legacy') - Extract nonce before async operations in both generators - Store nonce in variable to prevent multiple getNonce() calls This ensures nonce is allocated before any async work that might fail, preventing nonce gaps when gas estimation or other operations fail. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add console log to track nonce allocation for each label and owner in the legacy name generator. This will help identify when and where nonce mismatches occur during concurrent transactions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Document CI failure analysis after merging 4.0.3-alpha.12-branch - Fix nonce allocation timing in name generators to prevent race conditions - Add debug logging for nonce tracking in legacy generator 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Replace parallel Promise.all with sequential for loop when committing names to prevent nonce conflicts and race conditions during concurrent transaction execution. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Replace parallel Promise.all with sequential for loop when registering names to prevent nonce conflicts and ensure proper transaction ordering. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix import organization issues - Convert type-only imports to use 'import type' - Fix formatting in settings.local.json - Replace template literal with string literal where appropriate - Update nonceManager to handle optional parameter 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
Created comprehensive documentation file to guide future Claude Code instances working with the ENSjs codebase. Includes development commands, architecture overview, and important technical details. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Update @ensdomains/address-encoder to 1.1.3 - Update Universal Resolver address for mainnet - Add ensDefaultReverseRegistrar contract address - Remove CI failure analysis document - Update GitHub workflow and local settings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Applied Biome linter fixes to resolve error-level issues. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The tsconfig.node.json file is required by the tsn script command which is used by several package.json scripts (prepack, ver, generateDocs, rcBranchVersion). This file was previously deleted in commit d8a883f but is still referenced. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The prepack script has been removed from the package.json scripts section. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
commit: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.