Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: remove allow_slot_destroy_on_worker_threads runtime guard #38071

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wbpcode
Copy link
Member

@wbpcode wbpcode commented Jan 17, 2025

Commit Message: runtime: remove allow_slot_destroy_on_worker_threads runtime guard
Additional Description:

To close #38058

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@wbpcode wbpcode requested a review from mattklein123 as a code owner January 17, 2025 01:45
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #38071 was opened by wbpcode.

see: more, trace.

mattklein123
mattklein123 previously approved these changes Jan 17, 2025
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
@wbpcode
Copy link
Member Author

wbpcode commented Jan 18, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envoy_restart_features_allow_slot_destroy_on_worker_threads deprecation
3 participants