Skip to content

ci: fix errors in ci github action for node 8 and 9 #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2024
Merged

ci: fix errors in ci github action for node 8 and 9 #523

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd70fd1
ci: fix errors in ci github action for node 8 and 9
inigomarquinez May 5, 2024
8eff6fa
ci: remove minor version on node 22
inigomarquinez May 18, 2024
682461e
ci: remove minor versions
inigomarquinez May 24, 2024
2edaf6d
🧪 skip query test on node 21
jonchurch Jun 5, 2024
b360292
update query skip, actually skip, fix tracking issue link
jonchurch Jun 9, 2024
852555a
fix lint error for ==
jonchurch Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix lint error for ==
  • Loading branch information
@jonchurch
jonchurch committed Jun 9, 2024
commit 852555a87f7fccdac003235afc8550aaf8eda90f
2 changes: 1 addition & 1 deletion test/body-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ describe('bodyParser()', function () {
// update this implementation to run on supported versions of 21 once they exist
// upstream tracking https://github.com/nodejs/node/issues/51562
// express tracking issue: https://github.com/expressjs/express/issues/5615
return getMajorVersion(versionString) == 21
return getMajorVersion(versionString) === '21'
}

methods.slice().sort().forEach(function (method) {
Expand Down
Loading