Merged
Conversation
Pull Request Test Coverage Report for Build 21621055676Details
💛 - Coveralls |
bf296af to
8649781
Compare
8649781 to
5741bcb
Compare
5741bcb to
8236f71
Compare
ptondereau
requested changes
Feb 2, 2026
Member
ptondereau
left a comment
There was a problem hiding this comment.
we should keep the same behavior as PHP, so don't hesitate to use internal function
2f6b0ad to
4115cc5
Compare
Contributor
Author
I tried that and it led to some complications across PHP versions. I've decided to stick with Rust. Added more tests. |
Member
ok then it should be documented |
4115cc5 to
2a36359
Compare
a2eff9d to
03869f9
Compare
ptondereau
approved these changes
Feb 3, 2026
Merged
kakserpom
added a commit
to kakserpom/ext-php-rs
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework of #341