Skip to content

feat(zval): Zval coercion#632

Merged
ptondereau merged 1 commit intoextphprs:masterfrom
kakserpom:feat_zval_coercion
Feb 3, 2026
Merged

feat(zval): Zval coercion#632
ptondereau merged 1 commit intoextphprs:masterfrom
kakserpom:feat_zval_coercion

Conversation

@kakserpom
Copy link
Copy Markdown
Contributor

Rework of #341

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 22, 2025

Pull Request Test Coverage Report for Build 21621055676

Details

  • 110 of 115 (95.65%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 35.786%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/zval.rs 110 115 95.65%
Totals Coverage Status
Change from base Build 21601094043: 1.5%
Covered Lines: 2077
Relevant Lines: 5804

💛 - Coveralls

@kakserpom kakserpom force-pushed the feat_zval_coercion branch 3 times, most recently from bf296af to 8649781 Compare December 28, 2025 13:56
Copy link
Copy Markdown
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep the same behavior as PHP, so don't hesitate to use internal function

@kakserpom kakserpom force-pushed the feat_zval_coercion branch 5 times, most recently from 2f6b0ad to 4115cc5 Compare February 2, 2026 14:12
@kakserpom
Copy link
Copy Markdown
Contributor Author

@ptondereau

we should keep the same behavior as PHP, so don't hesitate to use internal function

I tried that and it led to some complications across PHP versions. I've decided to stick with Rust. Added more tests.

@kakserpom kakserpom requested a review from ptondereau February 2, 2026 16:34
@ptondereau
Copy link
Copy Markdown
Member

@ptondereau

we should keep the same behavior as PHP, so don't hesitate to use internal function

I tried that and it led to some complications across PHP versions. I've decided to stick with Rust. Added more tests.

ok then it should be documented

@ptondereau ptondereau merged commit 8f71582 into extphprs:master Feb 3, 2026
64 checks passed
@Xenira Xenira mentioned this pull request Feb 1, 2026
kakserpom added a commit to kakserpom/ext-php-rs that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants