Skip to content

feat(class): readonly and final classes#639

Merged
ptondereau merged 1 commit intoextphprs:masterfrom
kakserpom:readonly_class
Jan 25, 2026
Merged

feat(class): readonly and final classes#639
ptondereau merged 1 commit intoextphprs:masterfrom
kakserpom:readonly_class

Conversation

@kakserpom
Copy link
Copy Markdown
Contributor

@kakserpom kakserpom commented Dec 25, 2025

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 25, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 21317147072

Details

  • 3 of 8 (37.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 34.976%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/builders/module.rs 0 1 0.0%
crates/macros/src/class.rs 3 7 42.86%
Totals Coverage Status
Change from base Build 21296895878: -0.01%
Covered Lines: 1824
Relevant Lines: 5215
💛 - Coveralls

Xenira
Xenira requested changes Dec 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Xenira Xenira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Just a small adjustment.

@kakserpom kakserpom force-pushed the readonly_class branch 6 times, most recently from 9505f72 to 416e8ce Compare December 27, 2025 19:27
Xenira
Xenira previously requested changes Dec 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Xenira Xenira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we can re-use the build utility for the test crate as well.

@kakserpom kakserpom force-pushed the readonly_class branch 6 times, most recently from cadacb4 to d3733fc Compare December 28, 2025 11:52
@kakserpom kakserpom requested a review from Xenira December 28, 2025 13:58
Xenira
Xenira reviewed Dec 28, 2025
View reviewed changes
@kakserpom kakserpom requested a review from Xenira December 29, 2025 09:17
@kakserpom kakserpom force-pushed the readonly_class branch 4 times, most recently from b988fab to 81a8e36 Compare January 24, 2026 14:41
@kakserpom
Copy link
Copy Markdown
Contributor Author

kakserpom commented Jan 24, 2026

@Xenira @ptondereau All is rebased and green.

@kakserpom kakserpom force-pushed the readonly_class branch 2 times, most recently from b760f1c to 7fbd99c Compare January 24, 2026 15:10
ptondereau
ptondereau approved these changes Jan 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick but LGTM

@ptondereau ptondereau dismissed Xenira’s stale review January 25, 2026 08:12

The contributor addressed the reviews

@ptondereau ptondereau enabled auto-merge (squash) January 25, 2026 08:12
@ptondereau ptondereau merged commit 6013c2e into extphprs:master Jan 25, 2026
65 checks passed
@Xenira Xenira mentioned this pull request Jan 25, 2026
Merged
kakserpom added a commit to kakserpom/ext-php-rs that referenced this pull request Feb 5, 2026
@kakserpom
feat(class): readonly and final classes (extphprs#639)
cfe7d9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptondereau ptondereau ptondereau approved these changes

@Xenira Xenira Awaiting requested review from Xenira

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kakserpom @coveralls @Xenira @ptondereau