feat: add getRecommendedTimeoutMillis section on accessibilityInfo
#2581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simek
requested changes
Apr 7, 2021
Collaborator
Simek
left a comment
There was a problem hiding this comment.
Hi @grgr-dkrk, thank you for the update! 👍
Please retain the alphabetic order of methods on the page, use the required tag and table format as seen on, for example, Alert page:
Contributor
Author
|
@Simek Thanks! |
Collaborator
|
Thank you for the update, but the methods alphabetical order is still not correct: |
Simek
reviewed
Apr 7, 2021
Simek
reviewed
Apr 7, 2021
Simek
approved these changes
Apr 7, 2021
Collaborator
Simek
left a comment
There was a problem hiding this comment.
LGTM, thank so much you for all the review updates! 🙂
Contributor
|
Thank you @grgr-dkrk for fixing and documenting this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the features implemented in facebook/react-native#31063.