Skip to content

Enhance get derived state from props state warning - #12670 #13317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 3, 2018
Merged

Enhance get derived state from props state warning - #12670 #13317

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d73d3cc
Enhance warning message for missing state with getDerivedStateFromProps
Aug 3, 2018
24481a2
Adapt tests
Aug 3, 2018
ec8474c
style fix
Aug 3, 2018
0b54ed3
Tweak da message
gaearon Aug 3, 2018
d065525
Fix test
gaearon Aug 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style fix
  • Loading branch information
Felix Wu committed Aug 3, 2018
commit ec8474cf9253b3640c20d3c0e19ec5092f67cf94
9 changes: 6 additions & 3 deletions packages/react/src/__tests__/createReactClassIntegration-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,9 +510,12 @@ describe('create-react-class-integration', () => {
});
expect(() =>
ReactDOM.render(<Component />, document.createElement('div')),
).toWarnDev('Component state must be properly initialized when using getDerivedStateFromProps.', {
withoutStack: true,
});
).toWarnDev(
'Component state must be properly initialized when using getDerivedStateFromProps.',
{
withoutStack: true,
},
);
});

it('should not invoke deprecated lifecycles (cWM/cWRP/cWU) if new static gDSFP is present', () => {
Expand Down