Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the user to opt out of seeing "The above error..." addendum #13384

Merged
merged 6 commits into from
Aug 13, 2018
Merged

Allow the user to opt out of seeing "The above error..." addendum #13384

merged 6 commits into from
Aug 13, 2018

Commits on Aug 13, 2018

  1. Remove e.suppressReactErrorLogging check before last resort throw 

    It's unnecessary here. It was here because this method called console.error().
But we now rethrow with a clean stack, and that's worth doing regardless of whether the logging is silenced.
    @gaearon
    gaearon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    b1009e8 View commit details
    Browse the repository at this point in the history

  2. Don't print error addendum if 'error' event got preventDefault()

    @gaearon
    gaearon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    dd9f09d View commit details
    Browse the repository at this point in the history

  3. Add fixtures

    @gaearon
    gaearon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    977ae18 View commit details
    Browse the repository at this point in the history

  4. Use an expando property instead of a WeakSet

    @gaearon
    gaearon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    c433932 View commit details
    Browse the repository at this point in the history

  5. Make it a bit less fragile

    @gaearon
    gaearon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    da9d6f6 View commit details
    Browse the repository at this point in the history

  6. Clarify comments

    @gaearon
    gaearon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    2b22524 View commit details
    Browse the repository at this point in the history