Skip to content

[Float] support all links as Resources #25515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2022
Merged

[Float] support all links as Resources #25515

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f7339a
Support all links as potential Resources
gnoff Oct 19, 2022
8d26e62
prefetch-dns -> dns-prefetch
gnoff Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
prefetch-dns -> dns-prefetch
  • Loading branch information
@gnoff
gnoff committed Oct 21, 2022
commit 8d26e62b2987740e8bd27f3e63a2483dff943e62
2 changes: 1 addition & 1 deletion packages/react-dom-bindings/src/server/ReactDOMFloatServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ export function resourcesFromLink(props: Props): boolean {
resources.headsMap.set(key, resource);
switch (rel) {
case 'preconnect':
case 'prefetch-dns': {
case 'dns-prefetch': {
resources.preconnects.add(resource);
break;
}
Expand Down
10 changes: 5 additions & 5 deletions packages/react-dom/src/__tests__/ReactDOMFloat-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,7 @@ describe('ReactDOMFloat', () => {
<link rel="preload" href="bar" as="style" />
<link rel="stylesheet" href="bar" precedence="default" />
<link rel="preconnect" href="bar" />
<link rel="prefetch-dns" href="bar" />
<link rel="dns-prefetch" href="bar" />
<link rel="icon" href="bar" />
<link rel="icon" href="bar" sizes="1x1" />
<link rel="icon" href="bar" media="foo" />
Expand All @@ -965,15 +965,15 @@ describe('ReactDOMFloat', () => {
);
pipe(writable);
});
// "preconnect" and "prefetch-dns" get hoisted to the front.
// "preconnect" and "dns-prefetch" get hoisted to the front.
// All other generic links (not styles, or typed preloads)
// get emitted after styles and other higher priority Resources
// Sizes and Media are part of generic link keys
expect(getMeaningfulChildren(document)).toEqual(
<html>
<head>
<link rel="preconnect" href="bar" />
<link rel="prefetch-dns" href="bar" />
<link rel="dns-prefetch" href="bar" />
<link rel="stylesheet" href="bar" data-precedence="default" />
<link rel="foo" href="bar" />
<link rel="preload" href="bar" />
Expand Down Expand Up @@ -1001,7 +1001,7 @@ describe('ReactDOMFloat', () => {
<link rel="preload" href="bar" as="style" />
<link rel="stylesheet" href="bar" precedence="default" />
<link rel="preconnect" href="bar" />
<link rel="prefetch-dns" href="bar" />
<link rel="dns-prefetch" href="bar" />
<link rel="icon" href="bar" />
<link rel="icon" href="bar" sizes="1x1" />
<link rel="icon" href="bar" media="foo" />
Expand All @@ -1014,7 +1014,7 @@ describe('ReactDOMFloat', () => {
<html>
<head>
<link rel="preconnect" href="bar" />
<link rel="prefetch-dns" href="bar" />
<link rel="dns-prefetch" href="bar" />
<link rel="stylesheet" href="bar" data-precedence="default" />
<link rel="foo" href="bar" />
<link rel="preload" href="bar" />
Expand Down