Skip to content

[compiler] First cut at dep inference #31386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 22, 2024
Merged

[compiler] First cut at dep inference #31386

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
469ae32
Add env config to infer effect deps
jbrown215 Oct 30, 2024
3bd6f87
First cut of inferring effect deps
jbrown215 Oct 30, 2024
5d7cc78
Address PR feedback + run prettier
jbrown215 Nov 1, 2024
72b6f1b
No need to spread a filtered array
jbrown215 Nov 1, 2024
0481ddd
prettier again lol
jbrown215 Nov 1, 2024
cedc4b6
update tests
jbrown215 Nov 19, 2024
d99e393
update tests
jbrown215 Nov 19, 2024
d77ad3d
prettier
jbrown215 Nov 19, 2024
9b6d39f
refactor to use scope deps instead of FunctionExpression.dependencies
mofeiZ Nov 21, 2024
bd14dde
lints
mofeiZ Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
prettier
  • Loading branch information
@jbrown215
jbrown215 committed Nov 19, 2024
commit d77ad3d0bb3e6acab2ebcc283b507d2e48116484
2 changes: 1 addition & 1 deletion compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ function* runWithEnvironment(
name: 'PropagateScopeDependenciesHIR',
value: hir,
});

if (env.config.inferEffectDependencies) {
inferEffectDependencies(env, hir);
}
Expand Down
2 changes: 1 addition & 1 deletion compiler/packages/babel-plugin-react-compiler/src/HIR/Environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ const EnvironmentConfigSchema = z.object({
* the dependency.
*/
enableOptionalDependencies: z.boolean().default(true),

/**
* Enables inference and auto-insertion of effect dependencies. Still experimental.
*/
Expand Down
2 changes: 1 addition & 1 deletion compiler/packages/snap/src/compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ function makePluginOptions(
if (firstLine.includes('@inferEffectDependencies')) {
inferEffectDependencies = true;
}

let logs: Array<{filename: string | null; event: LoggerEvent}> = [];
let logger: Logger | null = null;
if (firstLine.includes('@logger')) {
Expand Down
Loading