Remove enableGetInspectorDataForInstanceInProduction flag #32033
+61
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: fd9cfa4...8552973 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
hoxyq
approved these changes
Jan 9, 2025
hoxyq
reviewed
Jan 9, 2025
Comment on lines
+31
to
+33
| let getInspectorDataForInstance: ( | ||
| closestInstance: Fiber | null, | ||
| ) => InspectorData; |
There was a problem hiding this comment.
If its no longer exported from renderer configs, should it be exported from ReactNativeFiberInspector?
There was a problem hiding this comment.
It's still referenced here from ReactNativeFiberInspector:
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
## Summary Callers for this method has been removed in facebook/react-native@65bda54, so these methods no longer need to be conditionally exported and the feature flag can be removed. ## How did you test this change? Flow fabric/native DiffTrain build for [74ea0c7](74ea0c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Callers for this method has been removed in facebook/react-native@65bda54, so these methods no longer need to be conditionally exported and the feature flag can be removed.
How did you test this change?
Flow fabric/native