This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Treath different image sizes as a diff#38
Open
mliljedahl wants to merge 1 commit intofacebookarchive:masterfrom
Open
Treath different image sizes as a diff#38mliljedahl wants to merge 1 commit intofacebookarchive:masterfrom
mliljedahl wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
Contributor
|
But the only way the size could have changed is if you specified it in the huxleyfile; if you did that, don't you already know the image's changed? |
Author
|
You are right, I left out that I modified the huxley code to load the full page with only the width set to a fix value. Still think this commit might be useful for the community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't see why the image size not should be treathed as a diff? This commit resizes the smallest image and fills the diff with the "diffcolor".