Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setup to install sksparse from pypi again #584

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Change setup to install sksparse from pypi again #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change setup to install sksparse from pypi.
  • Loading branch information
@luisenp
luisenp committed Jul 21, 2023
commit 95d18300b19f98759ce8969485873fa6ea30457e
2 changes: 1 addition & 1 deletion requirements/main.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
numpy>=1.19.2
scipy>=1.5.3
scikit-sparse>=0.4.5
scikit-sparse>=0.4.11
pytest>=6.2.1
pybind11>=2.7.1
semantic-version==2.10.0
Expand Down
5 changes: 0 additions & 5 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ def parse_requirements_file(path):
# Don't install functorch 0.2.1 if torch 1.13 already
# installed
continue
if "scikit-sparse" in line:
continue # version <= 0.4.8 broken in pypi, and 0.4.9 not uploaded
line = line.strip()
reqs.append(line)
return reqs
Expand Down Expand Up @@ -94,9 +92,6 @@ def maybe_create_baspacho_extension(has_cuda):

reqs_main = parse_requirements_file("requirements/main.txt")
reqs_dev = parse_requirements_file("requirements/dev.txt")
reqs_main += [
"scikit-sparse @ https://github.com/scikit-sparse/scikit-sparse/archive/refs/tags/v0.4.9.zip"
]
root_dir = Path(__file__).parent

is_nightly = False
Expand Down