Update Dependencies (Fix jitpack.io build) #377
Conversation
23dce44 to
0d424dc
Compare
| @@ -211,7 +211,7 @@ private void setFilter() { | |||
| */ | |||
| private void requestUserPermission() { | |||
| Log.d(TAG, String.format("requestUserPermission(%X:%X)", device.getVendorId(), device.getProductId() ) ); | |||
| PendingIntent mPendingIntent = PendingIntent.getBroadcast(this, 0, new Intent(ACTION_USB_PERMISSION), 0); | |||
| PendingIntent mPendingIntent = PendingIntent.getBroadcast(this, 0, new Intent(ACTION_USB_PERMISSION), PendingIntent.FLAG_IMMUTABLE); | |||
There was a problem hiding this comment.
I got no ideas the details here. But it seems 0 would be signifying on flags, and PendingIntent.FLAG_IMMUTABLE is 0x04000000.
So I assume you found that for some reason that flag is necessary?
There was a problem hiding this comment.
This change is required if you target Android 12.
It's on the example codebase, won't have any implication on the library itself.
| @@ -1,5 +1,6 @@ | |||
| VERSION_NAME=6.1.0 | |||
| VERSION_CODE=1 | |||
| ANDROID_BUILD_MIN_SDK_VERSION=12 | |||
| ANDROID_BUILD_MIN_SDK_VERSION=24 | |||
| ANDROID_BUILD_TARGET_SDK_VERSION=27 | |||
There was a problem hiding this comment.
Maybe would be nice if this could be higher, like android 34, or 33? Though it may not make a difference. I don't believe compiling our flutter app was needing android sdk 27 - so I assume the reason flutter dependencies can end up requiring older SDK versions is if flutter isn't relying on precompiled versions of flutter package's android code? In this case it's using a hosted pre-compiled version from maven/jitpack so it we don't need the compile sdk
There was a problem hiding this comment.
Changing target SDK version means that the library must behave as expected in the target environment.
I haven't checked the code for any breaking change targeting 34.
I am not confident on touching this version number if there is no real benefit to it.
0d424dc to
80170bb
Compare
80170bb to
0f16336
Compare
|
In commit 0f16336 i fixed the release artifacts naming. |
Build log:
https://jitpack.io/com/github/angelix/UsbSerial/fdefe94f65/build.log
Build Dependency