Skip to content

Conversation

@lfse-slafleur
Copy link
Member

No description provided.

@lfse-slafleur lfse-slafleur self-assigned this Jul 29, 2025
@lfse-slafleur lfse-slafleur marked this pull request as ready for review July 29, 2025 11:58
Copy link
Contributor

@MauriceHendrix MauriceHendrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, provided it works. Is the switch to awaredatetime relevant for fixing anything to do with calculating durations or what's the rationale?

@lfse-slafleur
Copy link
Member Author

looks good, provided it works. Is the swicth to awaredatetime relevant for fixing anything to do with calculating durations or what's the rationale?

@MauriceHendrix AwareDatetime enforces that any datetime must have a timezone associated with it. Especially useful on summer/winter time switches and cloud-based situations where some machines may use UTC and others CEST/CET. However, I changed it in the generation script mainly because the generated code already used AwareDatetime and it wasn't added to the generation script yet.

@lfse-slafleur lfse-slafleur merged commit 048c543 into main Jul 30, 2025
19 checks passed
@lfse-slafleur lfse-slafleur deleted the str_enum branch July 30, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants