This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
2aaa28e to
4055fc6
Compare
b1a8771 to
2962099
Compare
3b92e32 to
52793e1
Compare
0e52f39 to
6d59b23
Compare
mdebbar
approved these changes
Nov 23, 2021
Comment on lines
-479
to
-485
| /// Sanitizer used to convert const svg filter and clippath snippets to | ||
| /// SvgElement without sanitization. | ||
| class NullTreeSanitizer implements html.NodeTreeSanitizer { | ||
| @override | ||
| void sanitizeTree(html.Node node) {} | ||
| } | ||
|
|
| const int SVG_FEBLEND_MODE_COLOR = 15; | ||
| const int SVG_FEBLEND_MODE_LUMINOSITY = 16; | ||
|
|
||
| // Source: https://osscs.corp.google.com/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/graphics_types.cc;l=55;drc=59bdabfb96e4c7a0de476b24c34ff197d1fa2ce4 |
Contributor
There was a problem hiding this comment.
Is this link accessible from outside Google?
Comment on lines
1220
to
1221
| /// * https://osscs.corp.google.com/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/graphics_types.cc;l=55;drc=59bdabfb96e4c7a0de476b24c34ff197d1fa2ce4 | ||
| /// * https://osscs.corp.google.com/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc;l=725;drc=59bdabfb96e4c7a0de476b24c34ff197d1fa2ce4 |
| svgPath.setAttribute('fill', 'none'); | ||
| } else if (paint.color != null) { | ||
| sb.write('fill="${colorToCssString(color)}" '); | ||
| svgPath.setAttribute('fill', '${colorToCssString(color)}'); |
Contributor
There was a problem hiding this comment.
Suggested change
| svgPath.setAttribute('fill', '${colorToCssString(color)}'); | |
| svgPath.setAttribute('fill', colorToCssString(color)); |
| sb.write('stroke="${colorToCssString(color)}" '); | ||
| sb.write('stroke-width="${paint.strokeWidth ?? 1.0}" '); | ||
| sb.write('fill="none" '); | ||
| svgPath.setAttribute('stroke', '${colorToCssString(color)}'); |
Contributor
There was a problem hiding this comment.
Suggested change
| svgPath.setAttribute('stroke', '${colorToCssString(color)}'); | |
| svgPath.setAttribute('stroke', colorToCssString(color)); |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NullTreeSanitizer.Fixes b/198428641