[fuchsia] Remove mentions of fuchsia.deprecatedtimezone.#29509
[fuchsia] Remove mentions of fuchsia.deprecatedtimezone.#29509akbiggs merged 1 commit intoflutter:masterfrom
fuchsia.deprecatedtimezone.#29509Conversation
The FIDL library `fuchsia.deprecatedtimezone` is has not been used in Flutter for about a year now. Removing the mentions here, because the utilities that used to provide it will be removed too, making these tests fail. Removing the references will allow us to retire the timezone services.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I would not expect code removal to need any new tests beyond those already there. |
|
@filmil That bot won't stop you from submitting. |
|
Understood; just wanted to keep the comment on the record. |
|
Gotcha makes sense. |
|
I'd need some of you folks to merge this for me. I do not have commit rights. |
The FIDL library
fuchsia.deprecatedtimezoneis has not been used in Flutterfor about a year now. Removing the mentions here, because the utilities
that used to provide it will be removed too, making these tests fail.
Removing the references will allow us to retire the timezone services.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
Fixes flutter/flutter#93003
Pre-launch Checklist
writing and running engine tests.
///).