Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[fuchsia] Remove mentions of fuchsia.deprecatedtimezone.#29509

Merged
akbiggs merged 1 commit intoflutter:masterfrom
filmil:retire-deprecatedtimezone
Nov 3, 2021
Merged

[fuchsia] Remove mentions of fuchsia.deprecatedtimezone.#29509
akbiggs merged 1 commit intoflutter:masterfrom
filmil:retire-deprecatedtimezone

Conversation

@filmil
Copy link
Contributor

@filmil filmil commented Nov 3, 2021

The FIDL library fuchsia.deprecatedtimezone is has not been used in Flutter
for about a year now. Removing the mentions here, because the utilities
that used to provide it will be removed too, making these tests fail.

Removing the references will allow us to retire the timezone services.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

Fixes flutter/flutter#93003

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

The FIDL library `fuchsia.deprecatedtimezone` is has not been used in Flutter
for about a year now.  Removing the mentions here, because the utilities
that used to provide it will be removed too, making these tests fail.

Removing the references will allow us to retire the timezone services.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@filmil
Copy link
Contributor Author

filmil commented Nov 3, 2021

I would not expect code removal to need any new tests beyond those already there.

@akbiggs
Copy link
Contributor

akbiggs commented Nov 3, 2021

@filmil That bot won't stop you from submitting.

@filmil
Copy link
Contributor Author

filmil commented Nov 3, 2021

Understood; just wanted to keep the comment on the record.

@akbiggs
Copy link
Contributor

akbiggs commented Nov 3, 2021

Gotcha makes sense.

@filmil
Copy link
Contributor Author

filmil commented Nov 3, 2021

I'd need some of you folks to merge this for me. I do not have commit rights.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the mentions of fuchsia.deprecatedtimezone from Flutter embedder tests

2 participants