Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

iOS Background Platform Channels#29665

Merged
gaaclarke merged 3 commits intoflutter:mainfrom
gaaclarke:ios_background_platform_messages
Nov 19, 2021
Merged

iOS Background Platform Channels#29665
gaaclarke merged 3 commits intoflutter:mainfrom
gaaclarke:ios_background_platform_messages

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Nov 11, 2021 •
edited
Loading

issue: flutter/flutter#91635

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Nov 11, 2021
@gaaclarke gaaclarke force-pushed the ios_background_platform_messages branch 2 times, most recently from 0e26a3a to e96fac1 Compare November 13, 2021 01:00
@CaseyHillers CaseyHillers changed the base branch from master to main November 15, 2021 18:11
@gaaclarke gaaclarke force-pushed the ios_background_platform_messages branch 6 times, most recently from 8f9bdc2 to 0ba85eb Compare November 18, 2021 23:58
@gaaclarke gaaclarke marked this pull request as ready for review November 19, 2021 00:02
@gaaclarke gaaclarke requested a review from dnfield November 19, 2021 00:02
dnfield
dnfield approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

shell/platform/darwin/common/framework/Source/FlutterChannelsTest.m Outdated
codec:codec
taskQueue:taskQueue];
FlutterMessageHandler handler = ^(id _Nullable message, FlutterReply callback) {
NSLog(@"hey");
Copy link
Contributor

@dnfield dnfield Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: avoid extra logs even in tests

Copy link
Member Author

@gaaclarke gaaclarke Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

shell/platform/darwin/ios/platform_message_handler_ios.mm
Comment on lines 92 to 94
// Called from any thread.
// TODO(gaaclarke: This vestigal from the Android implementation, find a way
// to migrate this to PlatformMessageHandlerAndroid.
Copy link
Contributor

@dnfield dnfield Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just make it not purely virtual and have a no-op implementation in the base class?

Copy link
Member Author

@gaaclarke gaaclarke Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That just puts wallpaper over the issue. I'd like this to stick out like a sore thumb since it should be fixed. It's just a pain given how things are divided up.

@dnfield
Copy link
Contributor

dnfield commented Nov 19, 2021

...once CI is happy

@jmagman
Copy link
Member

jmagman commented Nov 19, 2021

The luci link is missing but the Mac Unopt failure is https://ci.chromium.org/p/flutter/builders/try/Mac%20Unopt/6227.
Rebase onto #29668

@gaaclarke gaaclarke force-pushed the ios_background_platform_messages branch from 15b6415 to 02293bb Compare November 19, 2021 18:59
@gaaclarke gaaclarke added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 19, 2021
@CaseyHillers CaseyHillers changed the base branch from master to main November 19, 2021 21:52
@gaaclarke
Copy link
Member Author

gaaclarke commented Nov 19, 2021

I'm landing this with luci-engine on red. It's not red if you actually check the status and autoroller PRs are landing and that check is not showing up red for them.

@gaaclarke gaaclarke merged commit 485b37c into flutter:main Nov 19, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2021
@engine-flutter-autoroll
485b37c iOS Background Platform Channels (flutter/engine#29665)
2f5b587
@gaaclarke gaaclarke mentioned this pull request Nov 20, 2021
Merged
3 tasks
dnfield added a commit that referenced this pull request Dec 12, 2021
@dnfield
Revert "iOS Background Platform Channels (#29665)"
28f2d0f 
This reverts commit 485b37c.
@dnfield dnfield mentioned this pull request Dec 12, 2021
Merged
dnfield added a commit that referenced this pull request Dec 12, 2021
@dnfield
Revert "iOS Background Platform Channels (#29665)" (#30289)
d91489e 
This reverts commit 485b37c.
This was referenced Dec 16, 2021
Open
Closed
gaaclarke added a commit to gaaclarke/engine that referenced this pull request Jan 5, 2022
@gaaclarke
iOS Background Platform Channels (flutter#29665)
c160f5c
@gaaclarke gaaclarke mentioned this pull request Jan 11, 2022
Merged
8 tasks
gaaclarke added a commit that referenced this pull request Jan 12, 2022
@gaaclarke
Reland: iOS Background Platform Channels (#29665) (#30697)
bdbd075 
* iOS Background Platform Channels (#29665)

* added test that passes before this change, and fails after it

* started supporting backwards compatible usage of setting handlers
JsouLiang pushed a commit to JsouLiang/engine that referenced this pull request Jan 14, 2022
@gaaclarke @JsouLiang
Reland: iOS Background Platform Channels (flutter#29665) (flutter#30697)
06c3ae1 
* iOS Background Platform Channels (flutter#29665)

* added test that passes before this change, and fails after it

* started supporting backwards compatible usage of setting handlers
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-ios platform-macos waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaaclarke @dnfield @jmagman