This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use a prebuilt Dart SDK during Fuchsia builds#29680
Merged
zanderso merged 1 commit intoflutter:masterfrom Nov 11, 2021
Merged
Conversation
9d20b48 to
1a0aa5e
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuchsia is an unusual target because we need to build the "engine artifacts", and there is a prebuilt Dart SDK for the host (mac, linuix), but no prebuilt Dart SDK for the target (fuchsia). In order to use the prebuilt Dart SDK for the host, which we need to make snapshot building go faster, this PR teaches the GN build that the prebuilt Dart SDK for the host and target can be for different OSes as well as for a different CPU architectures.
This brings the Fuchsia arm64 build down to ~2 minutes from ~15 minutes on CI, and unblocks building/running more Fuchsia tests.
In the future, if we need a prebuilt Dart SDK to target Fuchsia, we should follow the same pattern as for other platforms, and consume one vended by Dart infrastructure.
Fixes flutter/flutter#93084