Add 'explicit' to Android embedder constructors#29830
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Once the Android warning is fixed I will turn on the |
1e8e379 to
14e8bb6
Compare
|
Tree is actually green, the status isn't updating. Merging. |
Add
explicitto constructor declarations inandroid_debug.Include headers using header filter regex:
https://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html
Android version of #29741
For flutter/flutter#93576