Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Embedder Keyboard] Fix synthesized events causing crash#29854

Merged
fluttergithubbot merged 3 commits intoflutter:mainfrom
dkwingsmt:fix-empty-callback-key-event
Nov 22, 2021
Merged

[Embedder Keyboard] Fix synthesized events causing crash#29854
fluttergithubbot merged 3 commits intoflutter:mainfrom
dkwingsmt:fix-empty-callback-key-event

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Nov 20, 2021

This PR fixes a problem where synthesized events will cause crash, a bug introduced by #29638.

This PR also changes many keyboard-related tests in embedder_unittests.cc into using nullptr as the callback. This is because dealing with callback requires special setup (see test KeyDataResponseIsCorrectlyInvoked). Setting these useless callbacks to nullptr might help reduce confusion (which I actually encountered.)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: text input bug (regression) cla: yes crash embedder Related to the embedder API waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants