This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Embedder Keyboard] Fix synthesized events causing crash#29854
Merged
fluttergithubbot merged 3 commits intoflutter:mainfrom Nov 22, 2021
Merged
[Embedder Keyboard] Fix synthesized events causing crash#29854fluttergithubbot merged 3 commits intoflutter:mainfrom
fluttergithubbot merged 3 commits intoflutter:mainfrom
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes a problem where synthesized events will cause crash, a bug introduced by #29638.
This PR also changes many keyboard-related tests in
embedder_unittests.ccinto usingnullptras the callback. This is because dealing with callback requires special setup (see testKeyDataResponseIsCorrectlyInvoked). Setting these useless callbacks to nullptr might help reduce confusion (which I actually encountered.)Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.