This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix embedder_->EndFrame() not called in case of DrawLastLayerTree()#29979
Merged
fluttergithubbot merged 2 commits intoflutter:mainfrom Dec 5, 2021
Merged
Fix embedder_->EndFrame() not called in case of DrawLastLayerTree()#29979fluttergithubbot merged 2 commits intoflutter:mainfrom
fluttergithubbot merged 2 commits intoflutter:mainfrom
Conversation
5b5454f to
0b7783f
Compare
0b7783f to
ea1f306
Compare
ea1f306 to
4a9ccfe
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2021
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes this video flicker bug:
The root cause is EndFrame() is not called in case of
DrawLastLayerTree()when reusing previous layer tree.The detail context is in the issue 😁 flutter/flutter#94612
file_v2_37c4c961-3b3d-4d18-8838-ab9d66e6262g_videoCacheDE7C4520-DC0E-41F9-9EDE-3F5502F1B64B.origin.model.video.path.mov.mp4
And after this fix, the app works correctly:
ok.mp4
Pre-launch Checklist
writing and running engine tests.
///).