Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix embedder_->EndFrame() not called in case of DrawLastLayerTree()#29979

Merged
fluttergithubbot merged 2 commits intoflutter:mainfrom
eggfly:endframe_not_called
Dec 5, 2021
Merged

Fix embedder_->EndFrame() not called in case of DrawLastLayerTree()#29979
fluttergithubbot merged 2 commits intoflutter:mainfrom
eggfly:endframe_not_called

Conversation

@eggfly
Copy link
Member

@eggfly eggfly commented Nov 29, 2021

It fixes this video flicker bug:

The root cause is EndFrame() is not called in case of DrawLastLayerTree() when reusing previous layer tree.
The detail context is in the issue 😁 flutter/flutter#94612

file_v2_37c4c961-3b3d-4d18-8838-ab9d66e6262g_videoCacheDE7C4520-DC0E-41F9-9EDE-3F5502F1B64B.origin.model.video.path.mov.mp4

And after this fix, the app works correctly:

ok.mp4

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Nov 29, 2021
@eggfly eggfly force-pushed the endframe_not_called branch from 5b5454f to 0b7783f Compare November 29, 2021 12:19
@eggfly eggfly changed the title Fix external_embedder->EndFrame() not called in case of DrawLastLayerTree() WIP: Fix external_embedder->EndFrame() not called in case of DrawLastLayerTree() Nov 29, 2021
@eggfly eggfly force-pushed the endframe_not_called branch 2 times, most recently from 0b7783f to ea1f306 Compare December 2, 2021 14:12
@chinmaygarde chinmaygarde added the Work in progress (WIP) Not ready (yet) for review! label Dec 2, 2021
@eggfly eggfly force-pushed the endframe_not_called branch from ea1f306 to 4a9ccfe Compare December 3, 2021 16:06
@eggfly eggfly changed the title WIP: Fix external_embedder->EndFrame() not called in case of DrawLastLayerTree() Fix external_embedder->EndFrame() not called in case of DrawLastLayerTree() Dec 3, 2021
@eggfly eggfly requested review from blasten and iskakaushik December 3, 2021 16:53
@eggfly eggfly added platform-android and removed Work in progress (WIP) Not ready (yet) for review! labels Dec 3, 2021
@eggfly eggfly changed the title Fix external_embedder->EndFrame() not called in case of DrawLastLayerTree() Fix embedder_->EndFrame() not called in case of DrawLastLayerTree() Dec 3, 2021
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eggfly eggfly added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 5, 2021
@fluttergithubbot fluttergithubbot merged commit 68d320d into flutter:main Dec 5, 2021
@eggfly eggfly deleted the endframe_not_called branch December 5, 2021 15:12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 5, 2021
@eggfly
Copy link
Member Author

eggfly commented Dec 7, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants