This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add //flutter/fml/math.h with common math constants.#30425
Merged
chinmaygarde merged 2 commits intoflutter:mainfrom Dec 21, 2021
Merged
Add //flutter/fml/math.h with common math constants.#30425chinmaygarde merged 2 commits intoflutter:mainfrom
chinmaygarde merged 2 commits intoflutter:mainfrom
Conversation
This came up as I was [debugging failures on Windows](https://ci.chromium.org/p/flutter/builders/try/Windows%20Host%20Engine/30618?) due to use of the non-portable constants. Fixes flutter/flutter#82216
jason-simmons
approved these changes
Dec 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up as I was debugging failures on Windows due to use of the
non-portable constants.
Fixes flutter/flutter#82216