Add more info for --type in run_tests.py and add android into all type#30458
Add more info for --type in run_tests.py and add android into all type#30458fluttergithubbot merged 2 commits intoflutter:mainfrom
--type in run_tests.py and add android into all type#30458Conversation
--type in run_tests.py
chinmaygarde
left a comment
There was a problem hiding this comment.
The doc changes lgtm. But this changes the default behavior of the script. Not sure if this is the cause of the CI failure. But I agree, this all should include android.
Yes it changes the behavior, and I think it should include android into all, so I add it. The CI failure is in shell_unittests, seems like it's not related to android tests(android test is an apk installed into a device). Let me try the CI checking again. |
|
@chinmaygarde The last failed CI log: Maybe the shell_unittest is flaky or failed and then fixed. Now the CI test passed!
These scripts seems like they are rarely using the The last failed CI log: |
--type in run_tests.py--type in run_tests.py and add android into all type
…into all type (flutter/engine#30458)
It's a small improvement for
--typehelp, for who want to userun_tests.py.Pre-launch Checklist
writing and running engine tests.
///).