This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Replace Fuchsia logging macros (FX_LOG*) with FML logging#49970
Merged
mbrase merged 1 commit intoflutter:mainfrom Jan 24, 2024
Merged
Replace Fuchsia logging macros (FX_LOG*) with FML logging#49970mbrase merged 1 commit intoflutter:mainfrom
mbrase merged 1 commit intoflutter:mainfrom
Conversation
This change updates all of the Fuchsia specific logging macros (e.g. FX_LOG*) to use the logging macros provided by the FML library (FML_LOG(...)). This will allow us to migrate to Fuchsia structured logging backend in a future commit.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: code refactor with no semantic change |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 24, 2024
flutter/engine@0b9fce3...4bc368e 2024-01-24 jonahwilliams@google.com [Impeller] use const std::unique_ptr ref for Sampler type. (flutter/engine#49974) 2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from c353c00a4dcb to 9ea7cb490804 (1 revision) (flutter/engine#50005) 2024-01-24 mbrase@google.com Replace Fuchsia logging macros (FX_LOG*) with FML logging (flutter/engine#49970) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates all of the Fuchsia specific logging macros (e.g. FX_LOG*) to use the logging macros provided by the FML library (FML_LOG(...)). This will allow us to migrate to Fuchsia structured logging backend in a future commit.
flutter/flutter#141924
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.