This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Run stroke benchmarks on unclosed paths#50765
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Feb 19, 2024
Merged
[Impeller] Run stroke benchmarks on unclosed paths#50765auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
Contributor
Author
|
It's worth noting that I made a conscious decision to keep the name of the existing non-stroked benchmarks the same rather than prefix them with "closed_" in order to keep them connected to their history of measurements in the perf tracker. I could be swayed that having them be named more specific to their closed version of the path data is more important than the historical trends if reviewers think otherwise... |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 19, 2024
flutter/engine@b41494f...e96c18b 2024-02-19 flar@google.com [Impeller] Run stroke benchmarks on unclosed paths (flutter/engine#50765) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stroking benchmarks were using source paths that were completely closed which means that they were never testing the performance of stroke caps since none would be generated while widening the paths.
All stroking benchmarks are now run against unclosed versions of the paths to provide a mix of caps and joins in the measurements, and the non-stroking benchmarks are now also run against unclosed versions of the paths to add more measurements using the newly available test path data.
This change will affect all of the geometry benchmarks named "stroke_[Curve type][Cap][Join]". The Round and Square cap benchmarks will be the most affected and for the worse.